Allow adding additional box decoders in get_boxes#3
Closed
anayw2001 wants to merge 1 commit into
Closed
Conversation
alfg
added a commit
that referenced
this pull request
Jul 4, 2026
The extension point already existed (get_boxes_with_registry + Registry::with_decoder) but was invisible enough that PR #3 was opened to add what was already there. No new functionality: - add a worked doc example on get_boxes_with_registry showing the intended pattern: extend the default registry with a custom decoder (default_registry().with_decoder(...)) rather than replace it - re-export default_registry at the crate root - add an integration test proving a custom decoder fires through get_boxes_with_registry alongside the built-in decoders Supersedes PR #3.
Member
|
Thank you @anayw2001. I've added this as part of #7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for adding custom box decoders, since I couldn't find a way to use the user-defined registry, and it seems like the default registry already comes with a lot of useful parsers.