Fix BrickController - restoring MouldKing DI interface registration#237
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job BrickController Core Build
Fix BrickController Core build by restoring MouldKing DI interface registration
Jul 5, 2026
vicocz
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BrickController Core Buildjob was failing inVendorBuilderTestsbecause MouldKing devices had been switched toIMouldKingDeviceManager, but the Autofac registrations used by the tests did not expose that interface. This aligns the MouldKing constructor/registration path so the production container and test container resolve the same graph.MouldKing DI contract
IMouldKingDeviceManagerwith theGetAppId()contract used by MouldKing devicesMouldKingDeviceManagerConstructor dependency alignment
MK3_8,MK4,MK5,MK6MKBaseByteandMKBaseNibbleIMouldKingDeviceManagerinstead of the concrete manager typeAutofac registration fix
MouldKingDeviceManagerasIMouldKingDeviceManagerinMouldKingvendor registrationVendorBuilderTestsso the test container matches runtime DI behaviorResult
DependencyResolutionExceptionseen in the core build job for MouldKing device resolution