fix: the TUI tour gif stops racing its own workers - #213
Merged
Conversation
Three defects in scripts/gen_tui_gif.py, found by re-running it against the current TUI: - Frames were captured after a fixed per-command sleep, racing the @work(thread=True) workers that actually produce the output; one run shipped a /wiki list frame with no wiki list in it. Capture now waits on app.workers.wait_for_complete() plus a short render flush, and the magic settle column is gone from TOUR. - Headless, the app's Rich console defaults to 80 cols, so RichLog wrapped lines that fit the 110-col terminal (visible in the committed gif: /help descriptions and /kb list rows). The script now aligns console.width with the terminal size. - Chrome failures were silent: a missing binary raised a bare FileNotFoundError and render errors swallowed stderr. Now there is an upfront existence check and stderr in the raised error. docs/assets/tui.gif is regenerated with the fixed script; geometry is unchanged (1341x731, 5 frames). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KXrF6HMB12V1hC9xFtooDE
Owner
Author
|
CI is failing at the Install step on every job — repo-wide breakage, not this PR: lancedb 0.5.x no longer exists on PyPI. Tracked in #215; re-run checks once that lands. |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/gen_tui_gif.pyhealth check: three defects fixed, artifact regenerated.@work(thread=True)worker, but frames were captured after a fixed per-command sleep. A verification run shipped a/wiki listframe containing only "listing wiki pages…" — the results arrived one frame later. Capture now awaitsapp.workers.wait_for_complete()+ a 0.2s render flush; the per-command settle column is gone fromTOUR.RichLogmeasures content against it — so/helpdescriptions and/kb listrows wrapped even though they fit the 110-col terminal (visible in the previously committed gif). The script now setsconsole.widthto the terminal width. Real ttys never hit this.FileNotFoundError; render failure → stderr swallowed bycapture_output. Now: upfront existence check with a clear message, and stderr surfaced in the raised error.Verification
/wiki listframe reliably contains the wiki table;/helpand/kb listno longer wrap.docs/assets/tui.gifkeeps the exact original geometry (1341×731, 5 frames, 110×30 terminal).import-untypednote is pre-existing and CI only type-checkssrc/.Out of scope, tracked separately
/kb listshows 6 of 11 docs titleddoc-meta(KB fixture metadata listed as documents) — TUI/KB layer issue, filed as a separate issue.🤖 Generated with Claude Code
https://claude.ai/code/session_01KXrF6HMB12V1hC9xFtooDE