Report per-aln stats as per-aligned, ignoring unmapped reads#4921
Open
faithokamoto wants to merge 3 commits into
Open
Report per-aln stats as per-aligned, ignoring unmapped reads#4921faithokamoto wants to merge 3 commits into
faithokamoto wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg stats -areports aggregate bp/alignment stats as per aligned reads, ignoring unmapped readsDescription
The match bp/alignment and softclip bp/alignment stats would go up if you just aligned more reads, even if those alignments actually brought down the average bp per successful alignment. This change makes the denominator of the calculation be the count of reads with a primary alignment, instead of the count of reads period. Seems more meaningful.