Remove parameters that we don't use#4920
Open
faithokamoto wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
--item-scaleand--points-per-possible-matchfromvg giraffeas needless unused complexity.Description
Ignore the branch name; this was going to be something else before. Anyhow, this is the latest episode of "Faith tries to trim vg giraffe". Two parameters that we never change the defaults of and which were minor increases in algorithm complexity. I noticed these while trying to understand how scoring was working in DP. Having extra components to the scoring algorithm just made that more complicated.
--item-scaleis a multiplier applied to "yay we grabbed an item" score before any extra bonus is added. It was always 1, and its default was 1. Multiplying a number by 1 does not change anything.--points-per-possible-matchis a constant multiple for the number of bases which could end up as matches, applied as a bonus when scoring a transition. It was always 0, and its default was 0. Multiplying a number by 0 and then adding it into a score will never change the score by anything.These changes have no impact on anyone unless they were toying with these specific parameters themselves, but I doubt that. Simplifying the chain scoring calculation was nice for me.