Skip to content

Reduce excessive path indexing#4915

Open
adamnovak wants to merge 5 commits into
masterfrom
plan-path-indexing
Open

Reduce excessive path indexing#4915
adamnovak wants to merge 5 commits into
masterfrom
plan-path-indexing

Conversation

@adamnovak
Copy link
Copy Markdown
Member

@adamnovak adamnovak commented May 26, 2026

Changelog Entry

To be copied to the draft changelog by merger:

  • vg find -Q/--paths-named is now deprecated due to its partial-Protobuf output
  • vg find will now index its target paths but not other haplotype paths.
  • vg should no longer position-index haplotype paths unnecessarily in commands using the PathPositionOverlayHelper.

Description

This should fix cases where using the PathPositionOverlayHelper was making us index all haplotype paths.

I'm not sure if more commands need to be patched like vg paths to send along the names of haplotype paths they're actually interested in, to let queries on haplotype paths work. But we've only been indexing all the paths for a few months, and before that I think the behavior before that was for those queries to mysteriously give wrong answers.

@adamnovak adamnovak changed the title Plan path indexing Reduce excessive path indexing May 26, 2026
@adamnovak
Copy link
Copy Markdown
Member Author

I think we might need to fix vg stats --snarl-sample; I'm not sure it's under test with non-reference samples.

@adamnovak
Copy link
Copy Markdown
Member Author

This uses vgteam/libbdsg#241 in libbdsg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant