Cherries from Electrify model#108
Open
MichaelTiemann wants to merge 3 commits into
Open
Conversation
These changes have no singlefp, int32, nor lowmemory==3 changes. Should be good to go.
The code is now pretty opinionated that `vfoptions.experienceasset` is going to be set to a number, not a field that does or does not exist. Code tests the logical value of that field without checking it exists, which is fine. I came across some code that behaves the same way for `vfoptions.experienceassetz`, but that field is much less initialized throughout. This is perhaps one way to do so, and it could be ported to the FHorz case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are all changes that I made while working out the singlefp (1000+ files) and lowmemory changes (a handful of files that need to be generalized to hundreds of files). When merged, it will make my
singlefp_take2branch more pure.