fix(nbdkit): scope VDDK library path to nbdkit#154
Open
rhochmayr wants to merge 1 commit intovexxhost:mainfrom
Open
fix(nbdkit): scope VDDK library path to nbdkit#154rhochmayr wants to merge 1 commit intovexxhost:mainfrom
rhochmayr wants to merge 1 commit intovexxhost:mainfrom
Conversation
Member
|
rhochmayr thank you for this, can you take care of the sign-off please? |
Signed-off-by: rhochmayr <robert.hochmayr@gmx.at>
rhochmayr
force-pushed
the
fix/vddk-ld-library-path-leak
branch
from
d76b1c5 to
eec1662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This scopes
LD_LIBRARY_PATHto thenbdkitchild process instead of mutating the migratekit process environment globally.The VDDK plugin needs
/usr/lib64/vmware-vix-disklib/lib64on the library search path, but setting it withos.Setenvcauses the value to leak into later child processes.In particular, this affects
virt-v2v-in-place/supermin, where VMware's bundled OpenSSL libraries may be preferred over Fedora's system libraries and cause the symbol lookup failure reported in #153:Using
cmd.Envkeeps the VDDK library path limited to thenbdkitinvocation.Fixes #153