Group badge stories in Storybook - #299
Merged
Merged
Conversation
Organize badge-related Storybook stories under the Features/Badge hierarchy. Keep the component implementation locations unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group badge stories under Features/Badge
Summary
Storybook 上で feature 固有のバッジコンポーネントを見つけやすくするため、バッジ系 Story を
Features/Badge配下に集約します。主な変更点:
Features/Badge/*に統一UI/Badgeは既存の分類を維持やったこと
git diff --checkで差分を検証動作確認
git diff --check origin/main...HEADnpm run typecheck(依存パッケージ未導入のため実行環境で完走せず)Features/Badge配下の表示を確認レビュー & 動作確認 チェックリスト
Features/Badge配下に揃っていることUI/Badgeのままであること推奨テスト計画:
Features/Badge配下に 6 コンポーネントが表示されることを確認するその他気になることや相談ごと
ローカル環境に frontend の依存パッケージがなかったため、型チェックと Storybook の表示確認は未実施です。