Fix double-free via free_rr_data nullifying local variable instead of caller's pointer#156
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix double free via free_rr_data in utils.c
Fix double-free via free_rr_data nullifying local variable instead of caller's pointer
Jun 24, 2026
|
versat
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



free_rr_datanullified its localdatacopy instead of*pdata, leaving the caller's pointer dangling after the free. In loops acrossdirect.candforward.c, freeddata[0]/data[1]pointers could be passed toreset_rr_dataor freed again, triggering double-free/use-after-free.Change
utils.c—free_rr_data: replacedata = NULLwith*pdata = NULLso the caller's pointer is zeroed after the underlying struct is freed.