fix(verification/api): Return URL-safe nonce in challenge response sessions#428
Open
cowbon wants to merge 2 commits into
Open
fix(verification/api): Return URL-safe nonce in challenge response sessions#428cowbon wants to merge 2 commits into
cowbon wants to merge 2 commits into
Conversation
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
yogeshbdeshpande
left a comment
Collaborator
There was a problem hiding this comment.
please have a look!
Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Collaborator
|
@cowbon : I am not clear about this change, can we have a meeting today to understand the change? As far as I understand, Verifier does two things.
|
Collaborator
Author
Hi Yogesh, thanks for the info about the verifier design. However, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ratsd uses URL-safe base64 encoded nonce instead of standard encoded base64. See veraison/ratsd#37. Align the implementation so the nonce can be used directly from the
/challenge-response/v1/newSessionresponse body