tooling: opinion lint tier on; the workspace documented#142
Merged
Conversation
clippy::unwrap_used/panic/todo + missing_docs join the workspace lint floor (CI's -D warnings enforces them). Production unwraps (27) are gone for real: the desktop data layer's conn/auth locks route through poison-recovering helpers (a panicked holder's transaction has already rolled back; the session slot holds plain data), the server's rate-limit bucket map does the same, the three now_ms twins expect with the clock-before-1970 reason, and the dev tools stop panicking on empty stats or unreadable files. The 143 test-module unwraps carry the test-idiom allow. Every public item is now documented -- 338 doc comments across vegify-core (the domain model: per-100 g conventions, canonical grams, slug scopes, keyset paging), the api wire types (these flow into the generated TypeScript via specta, so bindings regenerate in this commit), the client SDK, the desktop data surface (the ttipc trait, per-command), the admin tool, and the config modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big one from the deferred ledger, done for content:
Lints:
clippy::unwrap_used/panic/todo+missing_docsjoin the workspace floor, enforced by CI's-D warnings.27 production unwraps eliminated for real -- the desktop data layer's conn/auth locks route through poison-recovering helpers (a panicked holder's transaction has already rolled back; the session slot is plain data), the server's rate-limit bucket map likewise, the three
now_mstwins expect with the clock-before-1970 reason, and the dev tools stop panicking on empty stats/unreadable files. 143 test-module unwraps carry the test-idiom allow.338 doc comments, written for content, none filler: vegify-core's domain model (per-100 g conventions, canonical grams, slug scopes, keyset paging), the api wire types (these flow into the generated TypeScript via specta -- bindings regenerate in this diff, +409 lines of TS docs), the client SDK, the desktop ttipc surface (per-command), the admin tool, config modules.
Full
just checkgreen;just bindingsbyte-stable on a second regen.