Fix memory leaks in speedtest exporter#29
Merged
Conversation
- Cache Prometheus handler instead of creating per-request (major optimization) - Explicitly nil serverList after use to aid garbage collection - Store metricsHandler in Exporter struct for reuse across scrapes This addresses the observed memory growth (2MB → 12MB → 16MB over 2 hours). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
veerendra2
marked this pull request as ready for review
June 2, 2026 12:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes observed memory growth (2MB → 12MB → 16MB over 2 hours) by optimizing handler allocation and improving garbage collection hints.
Close #28
Changes
promhttp.Handler()creation outside the request loop. Previously created a new handler instance per/metricsscrape, causing unnecessary allocations.serverList = nilafter extracting the target server to help GC reclaim the large server list object immediately.metricsHandlerfield to reuse across all scrapes.Impact
Testing
🤖 Generated with Claude Code