Add server_id query parameter support#27
Merged
Conversation
Allows overriding SERVER_ID on per-scrape basis via query param. Query param takes precedence over env var. Falls back to nearest server if specified server unavailable. Test locally: go build -o speedtest_exporter . ./speedtest_exporter & curl 'http://localhost:8080/metrics?server_id=1234' Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
veerendra2
commented
Jun 1, 2026
veerendra2
marked this pull request as ready for review
June 1, 2026 20:45
Tighten description and rename section for clarity. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows overriding
SERVER_IDon a per-scrape basis via query parameter on/metricsendpoint. Query param takes precedence over env var. Falls back to nearest server if specified server unavailable.Changes
NewMetricsHandler()to wrap Prometheus handler and extractserver_idquery paramTest Plan
go build -o speedtest_exporter .curl 'http://localhost:8080/metrics?server_id=1234'curl 'http://localhost:8080/metrics'(uses env var default)🤖 Generated with Claude Code