feat(author): add safe catalogue reconciliation (#2208) - #2247
Open
kevinatlee wants to merge 1 commit into
Open
Conversation
kevinatlee
marked this pull request as ready for review
August 27, 2026 00:21
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
kevinatlee
force-pushed
the
codex/author-catalogue-reconciliation
branch
3 times, most recently
from
August 27, 2026 19:34
294ccc1 to
54d7662
Compare
Signed-off-by: kevinatlee <kevin.atlee@live.ca>
kevinatlee
force-pushed
the
codex/author-catalogue-reconciliation
branch
from
August 27, 2026 19:35
54d7662 to
f3fa718
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filePath,ebookFilePath,audiobookFilePath, or abook_filesrecord; no filesystem deletion is involvedThe branch is rebased onto current
main, including the merged Hardcover language fix from #2246. Reconciliation remains a separate explicit operation and does not make refresh destructive. Refs #2208; the separate series-fill behavior described there is intentionally outside this PR.Suggested review order
internal/db/books.goandinternal/api/catalogue_reconciliation.go— deletion boundary and apply-time safeguardsinternal/metadata/aggregator_author_works.goand OpenLibrary completeness reporting — conservative catalogue evidenceinternal/api/catalogue_reconciliation_test.goandinternal/db/books_reconciliation_test.go— destructive/error-path coverageweb/src/components/CatalogueReconciliationModal.tsx— explicit preview and per-row selectionChecklist
git commit -s— see Sign your workdocs/DEPLOYMENT.mdupdated if env vars, config, or upgrade path changed (not applicable: no deployment/config change)changelog.d/(not an edit toCHANGELOG.md) — see changelog.d/README.mdTest plan
go test -timeout=30m ./cmd/... ./internal/...-count=10-count=10catalogue_reconciliation.goand forDeleteMetadataOnlyWantedByIDsgo vet ./...go build ./...golangci-lint run ./...(0 issues)govulncheck ./...(no called vulnerabilities)go test -count=1 -timeout=60s ./tests/smoke/...)The full backend run used
TMPDIR=/private/tmpon macOS so the existing rTorrent deletion safety test sees a direct path instead of the/var→/private/varsystem symlink.