Compile targeting Java 17#14886
Conversation
cholmcc
left a comment
cholmcc
left a comment
There was a problem hiding this comment.
See the individual comments below. There's no need to try to capture the specific Java installation, as
- in all likeliness, the installation system will have a new enough Java,
- it is not OK to specify alternatives when build, and
- build systems will have at least Java 17
| Uploaders: Christian Holm Christensen <cholmcc@gmail.com> | ||
| Build-Depends: | ||
| debhelper-compat (= 13), | ||
| default-jdk, |
There was a problem hiding this comment.
This is no good. A package cannot Build-Depends on a selection of packages. Just leave it at default-jdk. There's no chance that the package will be build on oldoldstable - which is the only distro release that has pre-17.
| Architecture: all | ||
| Depends: | ||
| bash (>= 5.0.0), | ||
| default-jre, |
There was a problem hiding this comment.
Similar to the above comment. Also, because a newer Java is used at build time, that requirement will automatically propagate to install-time.
There was a problem hiding this comment.
Leave it at default-jre. There's no need to change this at all.
| - name: Install build dependencies | ||
| run: | | ||
| dep=$(cat debian/control | \ | ||
| sed -E ':a ; $!N ; s/\n\s+/ /; ta P ; D' | \ |
There was a problem hiding this comment.
This change is not needed. See other comments.
| Source0: https://github.com/@REPOSITORY@/releases/download/@RELEASE@/VASSAL-@RELEASE@-linux.tar.bz2 | ||
| URL: https://vassalengine.org/ | ||
| BuildArch: noarch | ||
| Requires: java |
There was a problem hiding this comment.
This is dubious. There are really no releases that are stuck on Java 11 or earlier. I think you can do
Requires: java >= 1:1.17.0
2 participants
No description provided.