Property sheet trait improvement#13691
Open
geezer09 wants to merge 3 commits into
Open
Conversation
… can be changed directly in that window. Changed the behaviour so the state was saved when exiting that window instead of being reset
Collaborator
|
Thanks @geezer09, I'll have a closer look at this. |
Collaborator
|
Can you re-create this PR against the Release-3.7 branch for me? Thanks. |
rlament
reviewed
Mar 30, 2025
| Editor.PropertySheet.property_sheet_item=Property Sheet item | ||
| Editor.PropertySheet.name=Name | ||
| Editor.PropertySheet.type=Type | ||
| Editor.PropertySheet.State=State |
Contributor
There was a problem hiding this comment.
Not sure if case matters in the lookup, but this does not match line 932 in PropertySheet.java. It appears that the convention here is for all lowercase, so 'State' should be 'state'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is intended to address the same issue as PR #11974
It introduces changes to the
PropertySheetclass to include a new "state" property for each row in the property table. The most important changes include adding a new member variable to store the previous state, updating the table data structure to include the state, and modifying the method to retrieve the current state.Changes made to the state of properties in the property sheet window are reflected when accessing them via the gamepiece and vice versa.
After a bit of testing, it seems like these changes are quite tolerant to faulty user input.
Fixes #11861