Skip to content

fix: avoid duplicate anonymous error types - #153

Merged
haraldh merged 1 commit into
masterfrom
fix/generator-duplicate-error-types
Aug 9, 2026
Merged

fix: avoid duplicate anonymous error types#153
haraldh merged 1 commit into
masterfrom
fix/generator-duplicate-error-types

Conversation

@haraldh

@haraldh haraldh commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • prevent the error reply-method pass from emitting anonymous nested helper types
  • leave helper-type definitions to the error argument generation pass so each is emitted exactly once
  • add regression coverage and refresh generated fixtures and examples

Tests

  • cargo test -p varlink_generator

@coveralls

coveralls commented Aug 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 31330176035

Coverage remained the same at 56.477%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 2 of 2 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 5427
Covered Lines: 3065
Line Coverage: 56.48%
Coverage Strength: 14.09 hits per line

💛 - Coveralls

@haraldh
haraldh force-pushed the fix/generator-duplicate-error-types branch from 75728db to 0278410 Compare August 9, 2026 18:52
@haraldh

haraldh commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator Author

@lsjostro ping

@haraldh haraldh changed the title Fix generated identifiers and anonymous error types fix: avoid duplicate anonymous error types Aug 9, 2026
@lsjostro

lsjostro commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Oh nice! Thanks @haraldh ❤️

@haraldh
haraldh merged commit 2041093 into master Aug 9, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants