Email validation api#26
Conversation
thoven87
commented
May 14, 2025
- Updated HTTP Client to 1.26.0
- More information on the email validation API
* More information on the email validation API https://www.twilio.com/docs/sendgrid/ui/managing-contacts/email-address-validation/bulk-email-address-validation-overview * Updated the HTTP client to version 1.26.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
============================================
- Coverage 100.00% 89.47% -10.53%
============================================
Files 9 12 +3
Lines 145 266 +121
============================================
+ Hits 145 238 +93
- Misses 0 28 +28
🚀 New features to boost your workflow:
|
|
Phew -40% in code coverage dropped? Let's see if I can fix that :( |
fpseverino
left a comment
There was a problem hiding this comment.
Great job, I am very excited to add this API to the library!
I left some comments, thank you very much for the PR!
Thanks @fpseverino I will address the rest comments in a few. |
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
…ndgrid-kit into email-validation-api
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
Scratch what I said previously. How do we update |
fpseverino
left a comment
There was a problem hiding this comment.
A few more comments. Also, for all response types we have to make all properties optional, as we can't assume they will all be present when decoding them.
fpseverino
left a comment
There was a problem hiding this comment.
How do we update
uploadBulkValidationFilefor better code coverage? Or are you ok with the current drop in code coverage?
For now, it is not important. The more you can raise it the better
fpseverino
left a comment
There was a problem hiding this comment.
Looking much better, we're almost there! Thanks again
fpseverino
left a comment
There was a problem hiding this comment.
OK, let's merge it!
A PR of mine will follow, before the official release, in which I will update the DocC documentation and other such things.
I warn you that I may change the names of some methods or structures.
Thank you once again!
Unfortunately, you'll need to merge. I don't have permissions todo so. |