Skip to content

add x-client-id header#414

Merged
nilsnolde merged 1 commit intomasterfrom
nn-x-client-id-header
Apr 26, 2026
Merged

add x-client-id header#414
nilsnolde merged 1 commit intomasterfrom
nn-x-client-id-header

Conversation

@nilsnolde
Copy link
Copy Markdown
Member

👨‍💻 Changes proposed

This PR sends the X-Client-Id header to the valhalla service, so we can tell how many requests are done through the public web app (if they used the public service).

@github-actions
Copy link
Copy Markdown

Preview is ready! 🚀 You can view it here: https://valhalla-app-tests.gis-ops.com/414

@nilsnolde nilsnolde merged commit 7dae042 into master Apr 26, 2026
3 checks passed
@nilsnolde nilsnolde deleted the nn-x-client-id-header branch April 26, 2026 22:12
@chrstnbwnkl
Copy link
Copy Markdown
Member

Would it make sense to make this a .env var and use some non-default value for our deployment? Just to differentiate between people running a fork or a locally hosted version. Shouldn't be the case much but it's low hanging fruit

@nilsnolde
Copy link
Copy Markdown
Member Author

yep, added in 4ae8d1a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants