test: add per-class unit tests for trigger framework#24395
Open
mshabarov wants to merge 2 commits into
Open
Conversation
Direct unit tests for the small classes the existing TriggerTest only covered through full UI integration: - JsBuilderTest — reference()/captures() placeholder allocation and dedup, json() encoding of primitives and escape-prone strings. - LiteralInputTest — value encoding (incl. quote escaping) so a literal cannot break out of its surrounding JS expression. - PropertyInputTest — host vs non-host JS shape and property-name escaping in the bracket access. - HandlerInputTest — accepted in the owning trigger, rejected with IllegalArgumentException in any other. - SetPropertyActionTest — literal, Input-source, null literal, and escaped property name paths. - ClickTriggerTest — pins the modifier-key and clientX/Y factories that TriggerTest doesn't exercise. Plus TriggerTest gains one test for idempotent remove(). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Direct unit tests for the small classes the existing TriggerTest only covered through full UI integration:
Plus TriggerTest gains one test for idempotent remove().
Related-to #24361