test: drop incidental @vaadin/vaadin-themable-mixin and @vaadin/horizontal-layout npm deps#24391
Open
Artur- wants to merge 2 commits into
Open
test: drop incidental @vaadin/vaadin-themable-mixin and @vaadin/horizontal-layout npm deps#24391Artur- wants to merge 2 commits into
Artur- wants to merge 2 commits into
Conversation
…ontal-layout npm deps Five test AppShells declared @NpmPackage("@vaadin/vaadin-themable-mixin", version = TestVersion.VAADIN) without anything in their ITs depending on the mixin being explicitly loaded; the themable mixin is brought in transitively by the Vaadin web components those modules already use (text-field etc.). Drop the redundant annotation. FakeAppConf in test-prod-bundle declared @NpmPackage("@vaadin/horizontal-layout") to pad the shared prod bundle, but no IT verifies horizontal-layout is in the bundle and the only module that actually uses <vaadin-horizontal-layout> (test-theme-legacy-components-css-prod) declares its own @NpmPackage with a pinned version. Part of removing TestVersion.VAADIN usages so the constant can eventually be deleted. ITs that query Vaadin web components' shadow DOM (e.g., $("vaadin-input-container")) still need their @NpmPackage annotations and are left untouched; those go in a follow-up that swaps them to native elements.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five test AppShells declared @NpmPackage("@vaadin/vaadin-themable-mixin", version = TestVersion.VAADIN) without anything in their ITs depending on the mixin being explicitly loaded; the themable mixin is brought in transitively by the Vaadin web components those modules already use (text-field etc.). Drop the redundant annotation.
FakeAppConf in test-prod-bundle declared @NpmPackage("@vaadin/horizontal-layout") to pad the shared prod bundle, but no IT verifies horizontal-layout is in the bundle and the only module that actually uses (test-theme-legacy-components-css-prod) declares its own @NpmPackage with a pinned version.
Part of removing TestVersion.VAADIN usages so the constant can eventually be deleted. ITs that query Vaadin web components' shadow DOM (e.g., $("vaadin-input-container")) still need their @NpmPackage annotations and are left untouched; those go in a follow-up that swaps them to native elements.