ci: verify release tag against crate version instead of overwriting#38
Open
scarmuega wants to merge 1 commit into
Open
ci: verify release tag against crate version instead of overwriting#38scarmuega wants to merge 1 commit into
scarmuega wants to merge 1 commit into
Conversation
rust-sdk release.yml merged (#37) before the umbrella contract settled on manifest-as-source-of-truth versioning. Bring it in line with the other SDKs: - Add a verify job that checks the pushed tag equals the Cargo.toml version and fails fast on mismatch, before build/test/publish. - Drop the step that rewrote Cargo.toml from the tag; cargo publish no longer needs --allow-dirty. - Point the umbrella contract comment at the renamed reference/sdk-pipeline.md. Verification: workflow YAML syntactically validated only; not executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rust-sdk’s
release.ymlwas merged in #37 before the umbrella SDK release pipeline contract settled on manifest-as-source-of-truth versioning, somainstill carries the old tag-derived overwrite approach. This brings rust-sdk in line with the other SDKs.verifyjob that checks the pushedv*tag equals theCargo.tomlcrate version and fails fast on mismatch, before build/test/publish.Cargo.tomlfrom the tag;cargo publishno longer needs--allow-dirty.reference/sdk-pipeline.md.Pipeline:
verify→build→test→publish.Verification
Workflow YAML syntactically validated only. Not executed and the crate not built this session — the pipeline can only be exercised by a real tag push.
Operational prerequisite
The
CARGO_REGISTRY_TOKENrepository/org secret (a crates.io API token) must exist before the first release.