Add API request behavior tests#642
Open
HitanshiThakar wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
The added API request behavior tests are passing locally. |
utksh1
requested changes
Jun 7, 2026
Owner
utksh1
left a comment
There was a problem hiding this comment.
The API behavior tests need a rebase/fix before review can continue. Current required checks are failing, including frontend-checks, and backend jobs are skipped. Please rebase on the current CI baseline and make the tests pass cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added focused unit tests for frontend API request behavior covering the exported API functions from frontend/src/api.ts.
Created api.request-behavior.test.ts to cover:
successful API responses
non-OK HTTP responses
timeout and abort behavior
timeout cleanup during rejected requests
Also added fake timer usage and proper mock/timer restoration to avoid test leakage.
Related Issues
Closes #471
Type of Change
How Has This Been Tested?
Ran npx vitest run testing/unit/api.request-behavior.test.ts
7 tests passed
Checklist