fixed: Replaced Scans alert() failures with toast feedback#626
Open
pranavv2707 wants to merge 5 commits into
Open
fixed: Replaced Scans alert() failures with toast feedback#626pranavv2707 wants to merge 5 commits into
pranavv2707 wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced
alert()dialogs in the Scans page destructive-action failure paths with accessible toast notifications using the existingToastContext. Also adds test coverage for all three failure paths:Related Issues
Closes issue number #469
Type of Change
How Has This Been Tested?
Unit tests — 5 new tests in
Scans.failures.test.tsx:deleteTaskfailure shows error toast and keeps task in listbulkDeleteTasksfailure shows error toast and keeps tasks in listclearAllTasksfailure shows error toastChecklist
Issues Fixed
alert()dialogs for delete and clear-history failure paths, which block the page, cannot be styled, and are inaccessible to screen readers.alert()calls inhandleTaskDelete,handleClearAll, andhandleBulkDeletefailure paths withaddToast()from the existingToastContext.role="alert"so screen readers announce them automatically.Tests Added
frontend/testing/unit/pages/Scans.failures.test.tsx— 5 new tests covering:deleteTaskfailure shows error toast and keeps task in listbulkDeleteTasksfailure shows error toast and keeps tasks in listclearAllTasksfailure shows error toastHow to Test
cd frontend && npm run test— all 5 new tests should pass.npm run build— build should complete with no errors.Comments:
The backend-lint failure (F821 undefined name
dbin workflows.py) might be a pre-existing issue, not because of this PR.This change only modifies frontend/src/pages/Scans.tsx and frontend/testing/unit/pages/Scans.failures.test.tsx.
The ToolConfigTimeout max value mismatch is also pre-existing.
I apologise for the large number of commits.
Screenshots for checks
Description: The screenshot shows the passing of all 5 tests.
Description: The screenshot shows the successful building after the running of the tests, generating no warnings.