Skip to content

fix: clarify SES no-tracking config set failures #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
S1lander wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: clarify SES no-tracking config set failures #377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 26 additions & 13 deletions apps/api/src/services/SESService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,21 +213,34 @@ ${breakLongLines(attachment.content, 76, true)}`;
const configurationSetName =
TRACKING_TOGGLE_ENABLED && !tracking ? SES_CONFIGURATION_SET_NO_TRACKING : SES_CONFIGURATION_SET;

// Send via SES
const response = await ses.sendRawEmail({
Destinations: destinations,
ConfigurationSetName: configurationSetName,
RawMessage: {
Data: new TextEncoder().encode(rawMessage),
},
Source: `${from.name} <${from.email}>`,
});
try {
// Send via SES
const response = await ses.sendRawEmail({
Destinations: destinations,
ConfigurationSetName: configurationSetName,
RawMessage: {
Data: new TextEncoder().encode(rawMessage),
},
Source: `${from.name} <${from.email}>`,
});

if (!response.MessageId) {
throw new Error('Could not send email');
}

if (!response.MessageId) {
throw new Error('Could not send email');
return {messageId: response.MessageId};
} catch (error) {
const originalMessage = error instanceof Error ? error.message : String(error);
const noTrackingMessage =
TRACKING_TOGGLE_ENABLED && !tracking
? ' If this was a preview/test email, verify SES_CONFIGURATION_SET_NO_TRACKING exists in AWS SES.'
: '';

throw new Error(
`Failed to send email via SES using configuration set "${configurationSetName}".${noTrackingMessage} Original error: ${originalMessage}`,
{cause: error},
);
}

return {messageId: response.MessageId};
}

/**
Expand Down