fix(xsd): preserve xmllint diagnostics and distinguish infra failures - #14
Merged
Conversation
execFileSync errors were reduced to String(error.stderr), which produced a literal "undefined" message whenever stderr was empty (e.g. the ENOENT raised when xmllint isn't installed). That masked infrastructure failures as DpsXsdValidationError, causing callers to treat missing tooling as a permanent fiscal rejection. Add XmllintUnavailableError for cases where xmllint could not run to completion (missing binary, or a crash without stderr), keeping DpsXsdValidationError reserved for XSD violations that xmllint actually reported. Preserve message/code/path/spawnargs/stdout/stderr from the underlying error for diagnosis. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
execFileSync errors were reduced to String(error.stderr), which produced a literal "undefined" message whenever stderr was empty (e.g. the ENOENT raised when xmllint isn't installed). That masked infrastructure failures as DpsXsdValidationError, causing callers to treat missing tooling as a permanent fiscal rejection.
Add XmllintUnavailableError for cases where xmllint could not run to completion (missing binary, or a crash without stderr), keeping DpsXsdValidationError reserved for XSD violations that xmllint actually reported. Preserve message/code/path/spawnargs/stdout/stderr from the underlying error for diagnosis.