refactor: remove guest access from the get_site_name Frappe endpoint so the inte - #243
Draft
esafwan wants to merge 1 commit into
Draft
refactor: remove guest access from the get_site_name Frappe endpoint so the inte#243esafwan wants to merge 1 commit into
esafwan wants to merge 1 commit into
Conversation
The get_site_name whitelisted method leaked the internal tenant/site name to unauthenticated callers via allow_guest=True. It is now only available to authenticated sessions; the URYMosaic KOT display calls it with the user's session cookie, so authenticated usage is unaffected.
esafwan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does / Summary
Removes guest access from the
get_site_nameFrappe REST API endpoint inury/ury/api/ury_kot_display.pyby removingallow_guest=True.What it solves / Motivation
Key Technical Changes
ury/ury/api/ury_kot_display.py:@frappe.whitelist(allow_guest=True)to@frappe.whitelist().