Added BLE Radio on/off scanning. - #53
Open
btetz14 wants to merge 1 commit into
Open
Conversation
urish
requested changes
Jul 2, 2019
urish
left a comment
Owner
There was a problem hiding this comment.
Thanks, please have a look at my comments
| { | ||
| // Ble Radio On | ||
| JsonObject^ msg = ref new JsonObject(); | ||
| msg->Insert("_type", JsonValue::CreateStringValue("Start")); |
Owner
There was a problem hiding this comment.
Please change to "start" and "stop" (camelCase) to keep consistent with the other values for _type
| radio->StateChanged += ref new Windows::Foundation::TypedEventHandler<Windows::Devices::Radios::Radio^, Platform::Object^>( | ||
| [](Windows::Devices::Radios::Radio^ sender, Platform::Object^ args) | ||
| { | ||
| if (sender->State == Windows::Devices::Radios::RadioState::On) |
Owner
There was a problem hiding this comment.
This exact same code repeats a few lines above. I'd refactor it into a function that gets the radio state, creates the message and calls writeObject. In addition, you can write it more concisely as:
JsonObject^ msg = ref new JsonObject();
if (sender->State == Windows::Devices::Radios::RadioState::On) {
msg->Insert("_type", JsonValue::CreateStringValue("start"));
} else {
msg->Insert("_type", JsonValue::CreateStringValue("stop"));
}
writeObject(msg);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds BLE Radio on/off scanning. With a small update to bindings.js, noble.on stateChange will work.
This is the update needed to bindings.js