refactor: Prune dead config options, add CLI flags mirroring config#97
Merged
Conversation
delianides
changed the title
…ls, pr.layout) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add --no-pr/--view/--no-flash/--flash-duration/--scroll-padding/--edit-command flags that override config (precedence: flag > config > default), via merge_cli_overrides in main. Simplify App::new to take just the merged config (drop debounce_ms/base_override params; startup watcher now reads config.debounce_ms, fixing a startup/repo-switch inconsistency). Collapse the git worker's base_override/config_base params into a single base. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…g Agentic Workflows" Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Add view_mode_cli_and_config_spellings_agree test guarding that the serde (config) and clap::ValueEnum (--view) derives stay in sync. - Derive Default on Cli so bare_cli() uses struct-update syntax. - Build absent_flags_keep_config_values via struct-update, dropping the clippy::field_reassign_with_default allow. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
delianides
force-pushed
the
drew/collapse-config
branch
from
65cc0d6 to
ee02fd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[keys]section (keybindings are hardcoded),display.context_lines,pr.show_labels, and the deprecatedpr.layout. Existing config files using these still load — the keys are silently ignored.--no-pr,--view <MODE>,--no-flash,--flash-duration <MS>,--scroll-padding <N>,--edit-command <CMD>. The existing-d/--debounceand--basenow also override config (debounce default500now sourced from config/built-in defaults, not the flag).clap::ValueEnumonViewModeso--viewparses.App::newto take just the merged config (drop the separatedebounce_ms/base_overrideparams); the startup watcher now readsconfig.debounce_ms, fixing a prior inconsistency where startup used a CLI default but repo-switch used config. Collapse the git worker'sbase_override/config_baseparams into a singlebase.200→500).abouttext to "Tracking Real-Time Git Changes During Agentic Workflows".Test Plan
cargo test— full suite green (349 unit + integration, 0 failures), incl. new merge-precedence, ViewMode parse, and old-config-loads-gracefully testscargo clippy --all-targets -- -D warningscleancargo buildcleanperch --helpshows all flags and the new about text;perch --view bogusexits with a parse error