feat(docker): allow SVG icons for Docker containers#2663
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughDocker container UI icon rendering logic was refactored to check file extensions (PNG, SVG) against an array before selecting image-based output; the same fallback behavior for icon classes and FontAwesome icons remains. Host IP selection in port-binding logic had trailing whitespace removed while preserving conditional behavior. ChangesDocker Container UI Icon and Port Binding Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔧 PR Test Plugin AvailableA test plugin has been generated for this PR that includes the modified files. Version: 📥 Installation Instructions:Install via Unraid Web UI:
Alternative: Direct Download
|
Purpose
Right now only
.pngfiles are treated as valid Docker container icons in the WebGUI. Everything else falls back to FontAwesome icons.Added
Adds support for
.svgicons in the same rendering path as PNG icons.Notes
Summary by CodeRabbit
Refactor
Bug Fixes