Skip to content

feat: add proxy support#209

Open
vidarc wants to merge 2 commits into
ungoldman:mainfrom
vidarc:proxy
Open

feat: add proxy support#209
vidarc wants to merge 2 commits into
ungoldman:mainfrom
vidarc:proxy

Conversation

@vidarc

@vidarc vidarc commented Sep 8, 2025

Copy link
Copy Markdown

adds a new flag for some proxy support

went based off of the example shown here octokit/rest.js#43

makes use of https://github.com/nodejs/undici/blob/main/docs/docs/api/EnvHttpProxyAgent.md to just pull the proxy endpoint based on the users environment variables

@socket-security

socket-security Bot commented Sep 8, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedundici@​7.16.09910010097100

View full report

@vidarc

vidarc commented Oct 6, 2025

Copy link
Copy Markdown
Author

@ungoldman thoughts? would be a great addition for those of us behind a corporate proxy

@ungoldman

Copy link
Copy Markdown
Owner

Hi @vidarc, this looks reasonable, sorry for the long response time. I had a serious injury and have spent some time recovering. Taking a look today.

@ungoldman ungoldman left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vidarc looks good, the only thing I see missing is that your PR doesn't specify anywhere what environment variables are needed. Other users trying to use this feature will be left confused. If you can specify that in the README (perhaps in a brief ## Proxy section explaining the feature and how to use it) I'm happy to merge this.

Also have you tested that this works? I'm unable to test this particular configuration.

@vidarc

vidarc commented Oct 6, 2025

Copy link
Copy Markdown
Author

@ungoldman updated the docs

yea, have been making use of yarn patch to use this at work. was all i needed to get it to work with our setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants