feat: add proxy support#209
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@ungoldman thoughts? would be a great addition for those of us behind a corporate proxy |
|
Hi @vidarc, this looks reasonable, sorry for the long response time. I had a serious injury and have spent some time recovering. Taking a look today. |
There was a problem hiding this comment.
@vidarc looks good, the only thing I see missing is that your PR doesn't specify anywhere what environment variables are needed. Other users trying to use this feature will be left confused. If you can specify that in the README (perhaps in a brief ## Proxy section explaining the feature and how to use it) I'm happy to merge this.
Also have you tested that this works? I'm unable to test this particular configuration.
|
@ungoldman updated the docs yea, have been making use of yarn patch to use this at work. was all i needed to get it to work with our setup |
adds a new flag for some proxy support
went based off of the example shown here octokit/rest.js#43
makes use of https://github.com/nodejs/undici/blob/main/docs/docs/api/EnvHttpProxyAgent.md to just pull the proxy endpoint based on the users environment variables