chore: add govulncheck security scanning to CI#32
Open
em-redhat wants to merge 2 commits into
Open
Conversation
- Add Govulncheck step to ci.yml (after Vet, before Test) - Document govulncheck in AGENTS.md CI Parity Gate section - Add OpenSpec change artifacts (proposal, design, spec, tasks) Fixes unbound-force#23
The CI runner with go1.25.7 has 9 known stdlib vulnerabilities (GO-2026-4601 through GO-2026-4918) that cause govulncheck to fail. Updating to go1.25.11 resolves all of them.
sonupreetam
reviewed
Jul 13, 2026
|
|
||
| - name: Govulncheck | ||
| run: | | ||
| go install golang.org/x/vuln/cmd/govulncheck@latest |
Contributor
There was a problem hiding this comment.
@em-redhat Minor. Consider pinning to a commit hash instead of @latest (reproducibility, supply chain hygiene). Will approve once its done.
sonupreetam
requested changes
Jul 13, 2026
sonupreetam
left a comment
sonupreetam
left a comment
Contributor
There was a problem hiding this comment.
@em-redhat Do you think replicator should also adopt ci_security.yml with the org-infra reusable workflows (OSV-Scanner + Trivy + OpenSSF Scorecards) like the parent unbound-force/unbound-force repo does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
govulnchecksecurity scanning to the CI pipeline, implementing issue #23.Changes
.github/workflows/ci.yml: Add aGovulncheckstep afterVetand beforeTestthat runsgovulncheck ./...to detect known vulnerabilities in Go dependenciesAGENTS.md: Document that theBuild and TestCI check now includesgovulncheckfor vulnerability scanningopenspec/changes/ci-govulncheck/: Full OpenSpec change artifacts (proposal, design, spec, tasks)Design Decisions
govulncheckis added as a step within the existingBuild and Testjob (not a separate workflow), so the release preflight needs no changesgo install golang.org/x/vuln/cmd/govulncheck@latestto always get the most current vulnerability databaseVerification
govulncheck ./...passes locally (0 vulnerabilities in call graph)go test ./... -count=1 -race)go vet ./...passesFixes #23