You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that some displacements in Frankenstein do not follow the encoding guidelines by linking to another zone directly from a metamark tag rather than from an anchor tag. As a result, the linked zones do not appear in the reading text on the website. So far I have found two pages on which this occurs, but more may exist. I have adapted these two pages so that they follow the encoding guidelines produce the correct reading text. I've tested these changes using a script that produces a reading text similar to the one on the website.
After reading the encoding guidelines again, I noticed that linking to displacements from a metamark tag was actually allowed:
simply place a @corresp attribute in the zone element to link it to either the <anchor/> or <metamark> element within the main zone
I guess that means the code that produces the reading text on the website should probably be updated to support this feature. A programmatic search showed that the reading texts of the following pages should be affected by this issue:
I will be moving the links in these pages from <metamark> tags to <anchor/> tags anyway for use with my own scripts. I will update the PR when I'm done, and whoever maintains the repo/website can decide whether to fix the reading texts by merging or by changing the code that produces the reading texts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some displacements in Frankenstein
do not follow the encoding guidelines bylinkingto another zone directly from a metamark tag rather than from an anchor tag. As a result, the linked zones do not appear in the reading text on the website. So far I have found two pages on which this occurs, but more may exist. I have adapted these two pages so that theyfollow the encoding guidelinesproduce the correct reading text. I've tested these changes using a script that produces a reading text similar to the one on the website.