Accept normalized CLA signature comments - #51
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the single-line CLA workflow change. It correctly broadens signature-comment triggering while retaining an exact match for recheck; no genuine correctness, security, or compatibility issues found. LGTM.
|
🎉 PR #51 has been merged—thank you, @glenn-jocher!
This update makes the CLA workflow more resilient by accepting comments containing the required signature text, including trailing content such as a newline, while preserving an exact |
Updates the CLA workflow gate to allow signature comments containing harmless formatting such as a trailing newline, while keeping
recheckas an exact match.Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow to accept signature comments containing the required CLA text while preserving exact matching for
recheck.📊 Key Changes
contains(...).github.event.comment.body == 'recheck'as an exact match..github/workflows/cla.ymlonly; the workflow’s pull request and event conditions remain unchanged.🎯 Purpose & Impact
recheckmust remain exactlyrecheck.