Skip to content

Accept normalized CLA signature comments - #51

Merged
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828
Aug 28, 2026
Merged

Accept normalized CLA signature comments#51
glenn-jocher merged 1 commit into
mainfrom
cla-signature-gate-20260828

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 28, 2026

Copy link
Copy Markdown
Member

Updates the CLA workflow gate to allow signature comments containing harmless formatting such as a trailing newline, while keeping recheck as an exact match.

Validation:

  • actionlint .github/workflows/cla.yml
  • npx prettier@3.8.5 --check .github/workflows/cla.yml

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated the CLA workflow to accept signature comments containing the required CLA text while preserving exact matching for recheck.

📊 Key Changes

  • Changed the CLA signature check from exact equality to contains(...).
  • Kept github.event.comment.body == 'recheck' as an exact match.
  • Updated .github/workflows/cla.yml only; the workflow’s pull request and event conditions remain unchanged.

🎯 Purpose & Impact

  • CLA signature comments with additional surrounding content, such as a trailing newline, can now satisfy the workflow gate.
  • Comments must still contain the exact required CLA signature text, while recheck must remain exactly recheck.

@UltralyticsAssistant UltralyticsAssistant added the fixed Bug has been resolved label Aug 28, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/mobileclip 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/mobileclip main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the single-line CLA workflow change. It correctly broadens signature-comment triggering while retaining an exact match for recheck; no genuine correctness, security, or compatibility issues found. LGTM.

@glenn-jocher
glenn-jocher merged commit 9d40e93 into main Aug 28, 2026
9 checks passed
@glenn-jocher
glenn-jocher deleted the cla-signature-gate-20260828 branch August 28, 2026 16:09
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #51 has been merged—thank you, @glenn-jocher!

“Great things are done by a series of small things brought together.” — Vincent van Gogh

This update makes the CLA workflow more resilient by accepting comments containing the required signature text, including trailing content such as a newline, while preserving an exact recheck match and the existing event conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants