Implement spice of life upgrade#31
Open
ambrosia13 wants to merge 3 commits into
Open
Conversation
ambrosia13
commented
Apr 18, 2025
Collaborator
- adds field "uniquePatterns" in Level_manager to track the total unique number of patterns found so far (hash set)
- adds field "isDealtByPlayer" in Deal_damage component, and if this is true, and the spice of life modifier value is greater than zero, will multiply the damage dealt by the number of unique patterns and the modifier value
Rockyd3
requested changes
Apr 22, 2025
Rockyd3
left a comment
Collaborator
There was a problem hiding this comment.
2 things:
- When the upgrade isn't purchased and no patterns have been used yet, I believe the sword no longer does any damage. I assume it's getting multiplied by zero somewhere?
- This increments damage by 100% for each new pattern, not by 1%
If you could fix those that'd be much appreciated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.