Upgrades: Hardware Accel, Boot Up, Fortified#30
Open
SofiaAugusta wants to merge 6 commits into
Open
Conversation
…ues are not adjusted to proper values currently
Rockyd3
requested changes
Apr 22, 2025
Rockyd3
left a comment
Rockyd3
left a comment
Collaborator
There was a problem hiding this comment.
A lot of what you've done so far looks good, but I think there are a few big issues that need to be fixed. I left comments on a couple lines Player_Controller and Deal_Damage.
| public float normalSpeed = 5f; // Default movement speed | ||
| public float boostedSpeed = 7.5f; // 1.5x speed boost | ||
| public float boostDuration = 30f; // 30 seconds duration | ||
| public float boostDuration = 30f * Level_manager.instance.hardwareAccelUpgradeModifier; // base 30 seconds duration |
Collaborator
There was a problem hiding this comment.
I believe this is the duration of the speed boost (which the player gets for making a pattern and not the duration/length of the dash.
| // Decrease enemy damage based on fortified upgrade | ||
| if (gameObject.tag == "Enemy") | ||
| { | ||
| damage = baseDamage * Level_manager.instance.fortifiedUpgradeModifier; |
Collaborator
There was a problem hiding this comment.
I think your changes to the 'damage' variable are getting overwritten later in this same script. Also, please tag the enemy bullets as enemy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unsure on the implementation of bootup and fortified due to the current code structure.