MIDRC-1285 Validate token audience#110
Open
paulineribeyre wants to merge 13 commits into
Open
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Coverage Report for CI Build 27558089821Coverage increased (+0.2%) to 60.246%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions20 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
nss10
reviewed
Jun 15, 2026
| scopes, audience and purpose (all optional). | ||
|
|
||
| Args: | ||
| audience (Optional[str|set]) |
Avantol13
requested changes
Jun 24, 2026
Avantol13
left a comment
Avantol13
left a comment
Contributor
There was a problem hiding this comment.
remember to add info to "Breaking Changes" in the PR description
| scopes, audience and purpose (all optional). | ||
|
|
||
| Args: | ||
| audience (Optional[str|set]) |
|
|
||
| def set_current_user(**kwargs): | ||
| # If not already passed an aud to expect, default to the generic "gen3" aud | ||
| kwargs.setdefault("jwt_kwargs", {}).setdefault("audience", "gen3") |
Contributor
There was a problem hiding this comment.
"gen3" is a configuration in Fence, so it should ideally be a configuration or passed in here as an arg. If someone changes it - we need to allow that value here. Alternatively, we could not put it in config in Fence and just hard-code it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-1285
Reverts changes from #87, except the default audience is now "gen3"
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes