Bump gulp-rev from 9.0.0 to 12.0.0#1080
Conversation
Greptile SummaryThis PR bumps
Confidence Score: 1/5Not safe to merge — the upgrade introduces a pure-ESM package that is incompatible with the existing CommonJS gulpfile, causing an immediate build failure. gulp-rev 10+ is pure ESM and cannot be loaded with require(). gulpfile.js currently uses require('gulp-rev'), which will throw ERR_REQUIRE_ESM at runtime, completely breaking the asset build pipeline. This is a definite, reproducible breakage on the critical build path. gulpfile.js must be migrated to ES module syntax before this dependency upgrade can be accepted. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[gulp-rev v9.0.0\nCommonJS CJS] -->|bump to| B[gulp-rev v12.0.0\nPure ESM only]
B --> C{gulpfile.js\nuses require?}
C -->|Yes - current state| D[❌ ERR_REQUIRE_ESM\nBuild fails at startup]
C -->|No - after fix| E[✅ Build succeeds]
E --> F[gulpfile.mjs or\ntype: module in package.json]
Reviews (1): Last reviewed commit: "Bump gulp-rev from 9.0.0 to 12.0.0" | Re-trigger Greptile |
| @@ -20,7 +20,7 @@ | |||
| "gulp-inject": "^5.0.5", | |||
There was a problem hiding this comment.
ESM-only module breaks CommonJS gulpfile
gulp-rev v10.0.0 became a pure ESM package (see release notes: "This package is now pure ESM"). gulpfile.js loads it with var rev = require('gulp-rev') (line 18), which will throw ERR_REQUIRE_ESM at runtime under any Node.js version. The build will fail immediately when gulp tries to load the gulpfile. This upgrade requires either converting gulpfile.js to ES modules (rename to gulpfile.mjs or add "type": "module" to package.json) or replacing gulp-rev with a fork that still ships CJS.
c752260 to
6efd107
Compare
Bumps [gulp-rev](https://github.com/sindresorhus/gulp-rev) from 9.0.0 to 12.0.0. - [Release notes](https://github.com/sindresorhus/gulp-rev/releases) - [Commits](sindresorhus/gulp-rev@v9.0.0...v12.0.0) --- updated-dependencies: - dependency-name: gulp-rev dependency-version: 12.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
6efd107 to
d50e7a3
Compare
Bumps gulp-rev from 9.0.0 to 12.0.0.
Release notes
Sourced from gulp-rev's releases.
Commits
60ab15c12.0.063d666bMeta tweaksdcc2cd1Update dependencies and require Node.js 20 (#268)1e20ee111.0.0ea7c490Require Node.js 18a243f4d10.0.0ba8e68dMinor tweaks1a9b1e3Require Node.js 16 and move to ESM (#267)63b601bMeta tweaks1b3d0e6Add link to gulp-rev-dist-clean in the readme (#266)