Ignore large, all-surrounding input extents for intersection calculation - #208
Merged
Merged
Conversation
…extents which completely surround all others
Member
Author
|
I suspect that a working grid in Arctic Polar Stereographic projection would still have problems with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calculating intersections for the working grid, a very large input extent which completely surrounds all others contributes nothing to the intersection. However, if sufficiently large, its bounds may not be valid to reproject into the working grid projection, potentially causing errors. This problem is discussed in #204.
To avoid this, a simpler check can be done first, in geographic coordinates (lat/long), to see if one extent completely surrounds all others, and it can be removed before calculating the intersection bounding box. This makes it much easier to intersect with a global background dataset, while still only working in the intersection of the local inputs of interest.
This is only applied for INTERSECTION, it makes no sense for UNION.
@gillins, @petescarth. I have added some tests for this procedure, but I would love to see some real-life tests to make sure I have not broken anything.