Add const.py, move default creation options into it. - #203
Merged
Conversation
… of INTERSECTION, UNION, etc.
gillins
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This began as part of preparing to support Zarr format rasters. The per-driver check on overview support (in
calcstats.py) needed suitable creation options for Zarr (because Zarr V2 does not do overviews), but the default creation options are inimagewriter.py. This created a circular import, so I have moved the setup of default creation options into a separate module,const.py.The intention is that this new file can hold any constant values which might be needed across several modules, avoiding any future circular import problems. Not sure how much of this there will ever be, but still.
I have also moved the definitions of INTERSECTION, UNION, BOUNDS_FROM_REFERENCE, which were the last remaining important things in
imageio.py. Places which imported these symbols from imageio.py now import them from const.py, but they are also imported into imageio.py for backward compatibility, in case anyone was getting them from there.Generally, users should be importing all such symbols from applier.py, so they do not ever need to know about the various other modules.