Skip to content

Move commented import to end of import block#279

Merged
mernst merged 1 commit into
typetools:masterfrom
mernst:move-commented-import
May 26, 2026
Merged

Move commented import to end of import block#279
mernst merged 1 commit into
typetools:masterfrom
mernst:move-commented-import

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 26, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 675a77ab-4bb8-4e40-b04d-38aeb56f8d29

📥 Commits

Reviewing files that changed from the base of the PR and between 300678c and fcdbd85.

📒 Files selected for processing (57)
  • README.md
  • src/java.base/share/classes/java/io/BufferedReader.java
  • src/java.base/share/classes/java/lang/AbstractStringBuilder.java
  • src/java.base/share/classes/java/lang/CharSequence.java
  • src/java.base/share/classes/java/lang/StackStreamFactory.java
  • src/java.base/share/classes/java/lang/String.java
  • src/java.base/share/classes/java/lang/StringBuffer.java
  • src/java.base/share/classes/java/lang/StringBuilder.java
  • src/java.base/share/classes/java/lang/invoke/AbstractConstantGroup.java
  • src/java.base/share/classes/java/net/URL.java
  • src/java.base/share/classes/java/nio/charset/Charset.java
  • src/java.base/share/classes/java/nio/file/FileTreeIterator.java
  • src/java.base/share/classes/java/nio/file/Files.java
  • src/java.base/share/classes/java/nio/file/Path.java
  • src/java.base/share/classes/java/util/AbstractList.java
  • src/java.base/share/classes/java/util/AbstractMap.java
  • src/java.base/share/classes/java/util/ArrayDeque.java
  • src/java.base/share/classes/java/util/ArrayList.java
  • src/java.base/share/classes/java/util/Arrays.java
  • src/java.base/share/classes/java/util/Collections.java
  • src/java.base/share/classes/java/util/Enumeration.java
  • src/java.base/share/classes/java/util/HashMap.java
  • src/java.base/share/classes/java/util/HashSet.java
  • src/java.base/share/classes/java/util/Hashtable.java
  • src/java.base/share/classes/java/util/IdentityHashMap.java
  • src/java.base/share/classes/java/util/ImmutableCollections.java
  • src/java.base/share/classes/java/util/Iterator.java
  • src/java.base/share/classes/java/util/JumboEnumSet.java
  • src/java.base/share/classes/java/util/LinkedHashMap.java
  • src/java.base/share/classes/java/util/LinkedList.java
  • src/java.base/share/classes/java/util/List.java
  • src/java.base/share/classes/java/util/ListIterator.java
  • src/java.base/share/classes/java/util/PriorityQueue.java
  • src/java.base/share/classes/java/util/RegularEnumSet.java
  • src/java.base/share/classes/java/util/Scanner.java
  • src/java.base/share/classes/java/util/ServiceLoader.java
  • src/java.base/share/classes/java/util/Spliterators.java
  • src/java.base/share/classes/java/util/TreeMap.java
  • src/java.base/share/classes/java/util/Vector.java
  • src/java.base/share/classes/java/util/WeakHashMap.java
  • src/java.base/share/classes/java/util/concurrent/ArrayBlockingQueue.java
  • src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java
  • src/java.base/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java
  • src/java.base/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java
  • src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListMap.java
  • src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java
  • src/java.base/share/classes/java/util/concurrent/DelayQueue.java
  • src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java
  • src/java.base/share/classes/java/util/concurrent/LinkedBlockingQueue.java
  • src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
  • src/java.base/share/classes/java/util/concurrent/PriorityBlockingQueue.java
  • src/java.base/share/classes/java/util/concurrent/ScheduledThreadPoolExecutor.java
  • src/java.base/share/classes/java/util/regex/Matcher.java
  • src/java.base/share/classes/java/util/regex/Pattern.java
  • src/java.base/share/classes/java/util/zip/ZipFile.java
  • src/java.base/share/classes/sun/net/www/HeaderParser.java
  • src/java.base/share/classes/sun/net/www/MessageHeader.java

📝 Walkthrough

Walkthrough

This PR standardizes the ordering of Checker Framework annotation imports across 56 Java source files in the java.base module and updates a README shell script. All changes are mechanical: the org.checkerframework.framework.qual.* imports (AnnotatedFor, CFComment, DoesNotUnrefineReceiver) are repositioned to appear before the commented-out org.checkerframework.dataflow.qual.SideEffectsOnly import in each file. Additionally, one line in README.md is modified to add && \ for shell command continuation. No functional code, method signatures, or behavioral logic is altered.

Possibly related PRs

  • typetools/jdk#275: Also modifies SideEffectsOnly annotations in similar java.base files, but comments out active usages rather than reordering already-commented imports.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.3)
src/java.base/share/classes/java/lang/String.java
src/java.base/share/classes/java/util/Arrays.java
src/java.base/share/classes/java/util/Collections.java
  • 4 others

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mernst mernst merged commit 9300865 into typetools:master May 26, 2026
49 checks passed
@mernst mernst deleted the move-commented-import branch May 26, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant