Skip to content

Use local variables#7755

Open
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:local-vars
Open

Use local variables#7755
mernst wants to merge 1 commit into
typetools:masterfrom
mernst:local-vars

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 31, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: ae8206ba-058f-443f-b558-56c5b954df05

📥 Commits

Reviewing files that changed from the base of the PR and between cdae258 and 86b4490.

📒 Files selected for processing (2)
  • framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
  • framework/src/main/java/org/checkerframework/framework/util/AnnotatedTypes.java

📝 Walkthrough

Walkthrough

This PR refactors internal implementation details across two utility classes in the Checker Framework to improve code clarity and reduce repeated method calls. BaseTypeVisitor now explicitly imports NodeWithAnnotations, improves annotation insertion error messages by caching mismatched nodes, refactors early type-annotation handling in processMethodTree to reuse a local ModifiersTree, and optimizes postcondition error reporting by computing expressionString once. AnnotatedTypes refactors three utility methods to cache intermediate type-related values before use, eliminating redundant getter calls in substituteTypeVariables, adaptParameters, and containsModifierImpl.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant