Skip to content

Use gradle-git-properties version 4#7754

Merged
mernst merged 1 commit into
typetools:masterfrom
mernst:gitproperties4
May 31, 2026
Merged

Use gradle-git-properties version 4#7754
mernst merged 1 commit into
typetools:masterfrom
mernst:gitproperties4

Conversation

@mernst
Copy link
Copy Markdown
Member

@mernst mernst commented May 31, 2026

No description provided.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 31, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a3bd438b-5225-4488-8fe1-43fd49929758

📥 Commits

Reviewing files that changed from the base of the PR and between cdae258 and a64fd86.

📒 Files selected for processing (2)
  • checker/build.gradle
  • gradle/libs.versions.toml

📝 Walkthrough

Walkthrough

This pull request upgrades the gradle-git-properties Gradle plugin from version 3.0.3 to 4.0.0 in the version catalog and adds an explicit build task dependency. The sourcesJar task in checker/build.gradle now explicitly depends on generateGitProperties to ensure the git.properties file is generated before the sources jar is packaged, establishing proper build task ordering.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mernst mernst merged commit 91392e5 into typetools:master May 31, 2026
35 checks passed
@mernst mernst deleted the gitproperties4 branch May 31, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant