Phase 5: delete the CMake/vcxproj/MSVC build (licensed by the green differential) - #24
Merged
Conversation
The transitional PE differential ran green (25/25 x 3 arches), licensing the removal of the MSVC/CMake build. Delete .github/workflows/msbuild.yml (the MSVC reference lane) and the now-orphaned `differential` job in putup-release.yml that consumed it. The differential job was a leaf -- nothing depends on it; stage-linux, chm, cygterm, package, and publish are untouched and the release still ships. The permanent structural self-check (pe_diff.py selfcheck) stays in putup.yml.
Remove all 193 tracked Visual Studio project files (96 .vcxproj, 76 .vcxproj.filters, 14 .sln, 7 .slnx across the 7 solution families) -- the MSVC build the putup (clang-cl + xwin) build replaces. The vendored third-party VS solutions under libs/ (argon2, zlib) are git-ignored and downloaded at CI time, so they are unaffected.
Remove the 98 tracked CMake files of the MSVC/CMake build that putup replaces:
the main app (teraterm/ttssh2/TTProxy/TTXSamples/ttpmenu/tools), the fork's
libs/ build orchestration (buildall/lib_*/download/*.cmake), doc/installer/
buildtools CMake, and -- per decision -- all cygwin/ CMake except cygterm's
(cyglaunch/cyglib already have putup Tupfiles; the 32-bit cygtool.dll is unshipped
and unbuilt by putup). The third-party CMakeLists inside vendored libs/ sources
are git-ignored (downloaded at CI), so they are untouched.
Kept: cygterm's Cygwin-gcc build -- cygwin/cygterm/{CMakeLists.txt,
build_cygterm.cmake, toolchain_*-cygwin.cmake} + cygwin/cygterm_build/CMakeLists.txt.
The CMakeLists.txt ships inside cygterm+.tar.gz; CI builds cygterm via its Makefile.
Remove the Windows batch scripts that drove the MSVC/CMake build, now replaced by
the putup lane:
- installer/: release.bat, release_vs2026.bat, build_arch.bat, build_common.bat,
collect_files.bat (-> ci_scripts/stage_release.sh), create_package.bat, makelang.bat,
codesigning.bat, toolinfo_sample.bat, check_sjis_code.bat, checksymbol/start_checking.bat
- libs/: buildall.bat + build{SFMT,libressl,oniguruma6,openssl11,openssl3,zlib}.bat +
buildall_cmake.bat + openssl_patch/apply_patch.bat (putup vendors libs via curl)
- buildtools/: find_cygwin/find_perl/getcmake/getperl/install_msys2/install_linkchecker.bat,
svnrev/svnrev.bat, docker/docker_build.bat
- teraterm/susie_plugin/{,extlib/}build_vs2005_win32.bat
Kept: install_{cygwin,innosetup,sbapplocale}.bat, doc/makechm.bat + convtext.bat,
ci_scripts/find_cmake.bat -- all used by putup-release.yml's packaging. Only
explanatory comments in stage_release.sh / a Tupfile still name the old scripts.
- Remove the dead AppVeyor CI cluster (no root appveyor.yml exists): build_appveyor*
scripts, appveyor_*.yml variants, appveyor.md, addpkg_*/upgrade_syscygwin/notify.bat.
- Remove helpers orphaned with their deleted CMake pairs: gtags_update.bat,
ico_scripts/icon_{combine,extract}.bat.
- Delete the two build docs that only described the removed scripts (installer/
readme.md, installer/release.md). A develop-build.html rewrite for the putup
build is a follow-up doc task.
- .gitignore: drop the Visual Studio artifact lines (**/Debug/, **/Release/,
**/*.vs/, *.aps/*.ncb/*.suo/*.user).
- README.md: replace the dead msbuild.yml / build_cmake.yml CI badges with the
putup build + release workflows.
Nothing in the putup pipeline (putup.yml / putup-release.yml / their scripts)
referenced any removed file -- verified before deletion.
The full putup-release dispatch caught two mistakes in the deletion:
1. buildtools/install_{cygwin,innosetup,sbapplocale}.cmake are NOT part of the
MSVC build -- they are invoked (`cmake -P install_*.cmake`) by the kept
install_*.bat wrappers that putup-release.yml's cygterm/chm/package jobs use.
Deleting them broke those jobs ("CMake Error: Not a file: install_cygwin.cmake").
Restore them.
2. Over-reach: deleted the CMake for orthogonal dev tooling (doc_internal doxygen,
gtags source tags, icon generation) whose .sh/.bat wrappers survive. That is
not the app build putup replaces. Restore doc_internal/{doxygen,global}.cmake,
gtags_update.{cmake,bat}, and ico_scripts/icon_{combine,extract}.{cmake,bat}.
Also delete buildtools/docker/ -- the old CMake/mingw build's dev container, dead
now that libs/buildall.cmake + mingw.toolchain.cmake are gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transitional PE differential ran green (25/25 x 3 arches), proving the putup
(clang-cl + xwin) binaries are structurally equivalent to the MSVC build. That
licenses removing the legacy MSVC/CMake build. Five staged commits:
msbuild.ymland the now-orphaneddifferentialjob inputup-release.yml(a leaf; nothing depends on it)..vcxproj/.filters/.sln/.slnx.build (its
CMakeLists.txtships insidecygterm+.tar.gz). cyglaunch/cyglib haveputup Tupfiles; the 32-bit cygtool.dll is unshipped.
release.bat/build_arch.bat/build_common.bat/collect_files.bat(->stage_release.sh) + libs/buildtools/susie build scripts.docs,
.gitignoreVisual Studio lines, and the README CI badges (-> putup).~49k lines of build config removed. Kept: cygterm's build, the putup packaging
chain (install_*.bat, makechm.bat, convtext.bat, teraterm.iss, svnrev.pl), and
pe_diff.py's permanent self-check.Safety net
Deleting the MSVC lane removes zero coverage -- the green differential proved
equivalence, and
putup.ymlgates every push with the build matrix x3, therelease-manifest gate (every shipped binary builds),
pe_diff selfcheck, andtest-windows. I'll also dispatch the fullputup-release.yml(chm/cygterm/package)on this branch to exercise the release-packaging path the PR doesn't run.
Follow-up: a
develop-build.htmlrewrite for the putup build (docs were kept minimal here).