SMS and Account Self-Service API proofreading#104
Open
radekholy24 wants to merge 24 commits into
Open
Conversation
radekholy24
commented
Dec 21, 2021
radekholy24
commented
Dec 21, 2021
radekholy24
commented
Jan 3, 2022
radekholy24
changed the title
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
radekholy24
commented
Jan 3, 2022
Comment on lines
+1092
to
+1091
| originMNC: | ||
| type: string | ||
| type: number |
Contributor
Author
There was a problem hiding this comment.
Could not test it. Is this correct?
Contributor
There was a problem hiding this comment.
Nope according to the code, those values are indeed strings. So the example must have double quotes and the type should remain string
Contributor
Author
Contributor
Author
radekholy24
commented
Jan 3, 2022
Contributor
Author
|
@0xdeadbee, this is now ready to be reviewed. Can you please take a look? |
alextoulps
suggested changes
Jan 4, 2022
alextoulps
left a comment
alextoulps
left a comment
Contributor
There was a problem hiding this comment.
Couple of reverts needed. Other than that really nice, thanks!
Comment on lines
+1092
to
+1091
| originMNC: | ||
| type: string | ||
| type: number |
Contributor
There was a problem hiding this comment.
Nope according to the code, those values are indeed strings. So the example must have double quotes and the type should remain string
radekholy24
force-pushed
the
proofreading-sms
branch
3 times, most recently
from
ccf262c to
1594d0c
Compare
alextoulps
approved these changes
Jan 4, 2022
radekholy24
force-pushed
the
proofreading-sms
branch
from
1594d0c to
c14018d
Compare
radekholy24
commented
Jan 4, 2022
Comment on lines
562
to
571
| post: | ||
| tags: | ||
| - BYON Contact Service | ||
| summary: Create a contact | ||
| description: Creates a new contact. | ||
| security: | ||
| - ApiKeyHeader: [] | ||
| operationId: createContactUsingPOST | ||
| requestBody: | ||
| $ref: "#/components/requestBodies/ContactEntity" |
Contributor
Author
There was a problem hiding this comment.
@0xdeadbee, one last thing. It confuses me that the request to create a contact requires a comma-separated list but the content type is JSON. Shouldn't that be the text/csv content type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been assigned a task to proofread the API Reference. Alex has suggested to me to create a pull request for all my findings.