Set/Get object transparently#9
Open
kedoska wants to merge 4 commits into
Open
Conversation
added 4 commits
August 27, 2020 10:11
we want to encode and store the string as is but objects as JSON string.
Owner
|
Great idea, I like how simple this makes saving object data. However, I think this may introduce some breaking changes for people who are already manually managing what is set/get. I'm a bit hesitant to add the assumption that every non-string should be strigified. For example, Let me look into how some other cookie libraries deal with this sort of thing. I know some popular libraries like js-cookie leave it up to the user to define how encoding/decoding works. I could also see this being set during initialization for more flexibility, maybe something along the lines of: const [user, setUser] = useCookie('user',
{username: 'test', id: 1000},
{
encode: JSON.stringify, // or a custom function of your making
decode: JSON.parse
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set an object
Get an object