Skip to content

Fix issues#23

Closed
chpio wants to merge 6 commits into
tylerwolff:masterfrom
chpio:ts
Closed

Fix issues#23
chpio wants to merge 6 commits into
tylerwolff:masterfrom
chpio:ts

Conversation

@chpio

@chpio chpio commented Jun 9, 2021

Copy link
Copy Markdown

Hi,

this PR changes:

  • fixes TS declarations. The old one took a undefined | string as initialValue but returned string, which is wrong.
  • removes initialValue
  • fixes hydration mismatch between SSR & browser rendering
  • rewrites the js code to ts (no need to maintain separate TS declarations)

issues:

chpio added 5 commits June 9, 2021 11:47
This is a *lib*, thus there's no need for a lock file.
* Removed `initialValue` argument (<tylerwolff#16 (comment)>)
* Fixed hydration mismatch between SSR & browser rendering (<tylerwolff#12 (comment)>)
@chpio chpio closed this Jun 22, 2021
@chpio

chpio commented Jun 22, 2021

Copy link
Copy Markdown
Author
  1. seems there's no interest in this
  2. i guess it's because it changes to much? going to need to release my own fork.

edit: i was waiting/hoping for some inputs here or in #16

@chpio chpio deleted the ts branch June 22, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant