fix: resolve --skip-to from workflow DAG instead of hardcoded job list#25
Open
tylerpayne wants to merge 1 commit into
Open
fix: resolve --skip-to from workflow DAG instead of hardcoded job list#25tylerpayne wants to merge 1 commit into
tylerpayne wants to merge 1 commit into
Conversation
--skip-to used a hardcoded _JOB_ORDER list that only knew the five standard jobs. Workflows with custom jobs between them (e.g. a checks job before build) were not handled correctly. Now reads the actual release.yml, builds the needs DAG, and computes ancestors of the target job via BFS. Falls back to the default order when no workflow file exists. Custom CI-only job names are merged into plan.skip so the workflow if-condition gates them properly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-toused a hardcoded_JOB_ORDERlist that only knew the five standard jobs (validate, build, release, publish, bump). Workflows with custom jobs between them were not handled correctly.release.yml, builds theneeds:DAG, and computes ancestors of the target job via BFS. Falls back to the default linear order when no workflow file exists.plan.skipafter plan construction so the workflowif: !contains(...)condition gates them properly.Test plan
compute_ancestors(linear chain, custom job, root node, missing target, diamond, parallel branch)--skip-towith custom workflow jobs, targeting custom jobs, and unknown jobs with workflow file present🤖 Generated with Claude Code