Skip to content

Fixed configuration and custom item effects#42

Open
dandyjay wants to merge 5 commits into
txnimc:masterfrom
dandyjay:master
Open

Fixed configuration and custom item effects#42
dandyjay wants to merge 5 commits into
txnimc:masterfrom
dandyjay:master

Conversation

@dandyjay

Copy link
Copy Markdown

Merged with pull #35 by request of the owner and fixed the most crippling bug of the mod ( #18, #6 ). Added functionality and some new text for custom effects. Also added some new configuration settings, namely "displayEffects" and "maxFoodHealth" (inspired by #27)

@Tempest-5ky

Copy link
Copy Markdown

Thanks so much for this! I apparently don't have the programming knowledge myself, so if this is far more complicated than is convenient absolutely disregard, but do you know if it's at all possible to have the option for exhaustion/hunger effects to drain the timer faster? Tried it myself, couldn't quite get it to work.

@dandyjay

dandyjay commented Jan 9, 2025

Copy link
Copy Markdown
Author

do you know if it's at all possible to have the option for exhaustion/hunger effects to drain the timer faster? Tried it myself, couldn't quite get it to work.

I think it could be possible for sure. The way I see it there's two approaches:

  • the player gets hunger effect / exhaustion and it removes some time off the timer
  • the timer checks for the presence of the hunger effect and ticks twice as fast

I would probably avoid exhaustion, but there's room for interesting gameplay elements with the hunger effect ticking twice as fast.

@Tempest-5ky

Copy link
Copy Markdown

I think ticking twice as fast would be the best approach, as well as perhaps some kind of indicator on the number or timer itself; a colour change, for example. The former at least is more or less what I was trying to pull off, but when I couldn't get it to work properly, thought i'd pass the idea off to someone with a bit more experience with the mod's code 😅

@MarioSMB

Copy link
Copy Markdown

Nice work, thanks!

As a bit of a scope creep suggestion, would it be possible to extend the item registry loop to also include modded items in the config?

@MarioSMB

Copy link
Copy Markdown

Been playing with this and I think there's a small issue: values changed on the server aren't sent to clients, so without updating their configs they don't actually know the food's stats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants